[pvrusb2] bitmask cleanup / new patch / newer..

Ingo Flaschberger if at xip.at
Fri Jan 6 18:16:18 CST 2006


Hey..

Seems to be my good day...

version 3 works now.

But in file driver/pvrusb2-hdw.h I have no idea why I can't replace
#define PVR2_SUBSYS_ENC_FIRMWARE        0x00000001
#define PVR2_SUBSYS_ENC_CFG             0x00004000
#define PVR2_SUBSYS_DIGITIZER_RUN       0x00008000
#define PVR2_SUBSYS_USBSTREAM_RUN       0x00010000
#define PVR2_SUBSYS_ENC_RUN             0x00020000

with:
#define PVR2_SUBSYS_ENC_FIRMWARE        1 << 0
#define PVR2_SUBSYS_ENC_CFG             1 << 14
#define PVR2_SUBSYS_DIGITIZER_RUN       1 << 15
#define PVR2_SUBSYS_USBSTREAM_RUN       1 << 16
#define PVR2_SUBSYS_ENC_RUN             1 << 17


It just does not work. Also ((unsigned long) 1) << 0 casts does not help.
Strange...

bye,
 	ingo flaschberger

geschaeftsleitung
crossip communications gmbH
------------------------------
sebastian kneipp gasse 1
a-1020 wien
fix: +43-1-726 15 22-217
fax: +43-1-726 15 22-111
mob: +43-699-105 86 719
www.xip.at
------------------------------
On Sat, 7 Jan 2006, Ingo Flaschberger wrote:

> Hey...
>
> never release something before doing a compile... grml.
> new one without syntax errors.
>
> thnx & bye,
> 	ingo flaschberger
>
> geschaeftsleitung
> crossip communications gmbH
> ------------------------------
> sebastian kneipp gasse 1
> a-1020 wien
> fix: +43-1-726 15 22-217
> fax: +43-1-726 15 22-111
> mob: +43-699-105 86 719
> www.xip.at
> ------------------------------
> On Sat, 7 Jan 2006, Ingo Flaschberger wrote:
>
>> Hi Mike,
>> 
>> In the next patch all bitmask's are "cleaned".
>> means: no more 0x00001 but 1 << 0;
>> Easier to read.
>> 
>> Hope it's ok.
>> The pvrusb2-debug.h is included again.
>> 
>> bye,
>> 	ingo flaschberger
>> 
>> geschaeftsleitung
>> crossip communications gmbH
>> ------------------------------
>> sebastian kneipp gasse 1
>> a-1020 wien
>> fix: +43-1-726 15 22-217
>> fax: +43-1-726 15 22-111
>> mob: +43-699-105 86 719
>> www.xip.at
>> ------------------------------


More information about the pvrusb2 mailing list