[pvrusb2] 20051016/driver/tveeprom.c ppc build breakage with kernel 2.6.14

[Mike Isely]

On Fri, 28 Oct 2005, Per Christian Henden wrote:

> On Friday 28 October 2005 20:04, Per Christian Henden wrote:
>> Hi,
>>
>> When compiling the 20051016 driver snapshot on my linux PPC system I get
>> the following error
>>
>> make[1]: Entering directory `/usr/src/linux-2.6.14'
>>   CC [M]  /home/perchrh/src/pvrusb2-mci-20051016/driver/tveeprom.o
>> /home/perchrh/src/pvrusb2-mci-20051016/driver/tveeprom.c:50:25: error:
>> asm/segment.h: No such file or directory
>>
>> include/asm-ppc*/segment.h
>> seems to be missing in kernel 2.6.14
>> they are in place in 2.6.13
>>
>>>> From the 2.6.14 ChangeLog
>>
>>     [PATCH] ppc32: remove use of asm/segment.h
>>
>>     Removed ppc32 architecture specific users of asm/segment.h and
>>     asm-ppc/segment.h itself
>>
>> I commented out the include line from driver/tveeprom.c and the file
>> compiled, and the driver is working.
>>
>> Other architectures seem to have their segment.h files, except ppc64, that
>> is. Do the driver need segment.h in order to work on the other platforms?
>>
> Update: It doesn't seem like the include is needed on recent 2.6 kernels on
> x86 either,
> builds correctly against 2.6.14-rc4, 2.6.12.3, 2.6.11.7+v4l patches and
> 2.6.13.4
>
> As tveeprom.c is from the ivtv package, maybe we should file a bug report with
> them, if it't not fixed in their latest snapshot.
>
> -PER

I'm really hesistant to patch tveeprom.c, because it's from ivtv, not 
anything I write or maintain.  I definitely don't want to start 
maintaining patches against it.  However I'll look to see if there has 
been an update, and if the latest version from there still has this 
problem it would be a good idea to point it out to them.

Anyone trying ivtv on ppc in 2.6.14 should have the same problem.

   -Mike

-- 
                         |         Mike Isely          |     PGP fingerprint
      Spammers Die!!     |                             | 03 54 43 4D 75 E5 CC 92
                         |   isely @ pobox (dot) com   | 71 16 01 E2 B5 F5 C1 E8
                         |                             |