[pvrusb2] Misplaced Filter-Controls?

[Carsten Meier]

Hi Mike,

I'm currently having a little bit of headache with the filter-controls.
Aren't they misplaced in the MPEG-class? I think they should actually go
to the user-controls. The background is the following:

I want to present the user a menu where controls of the user-class can
be edited on a per-channel-basis. (because each channel has it's own
understanding of black-level etc.) Some channels are more distored than
others, so here I like to increase the temporal-filter (currently in
textual config-files). But this won't work for UI-dialogs, because the
MPEG-controls should only be visible in an encoder-profiles-dialog
which is independant of channels (for bitrate, GOP-size, etc)

I also think that the filter-controls are better suited to the
user-class, because they affect the image and not the encoding process
as such.

Changing it would be a little bit difficult, because the controls are
defined in the v4l-header. But I think it was wrong to put them there
anyway, as they are private controls.

What do you think?

Cheers,
Carsten